Activity log
- Created & dismissed (max. allowed matches exceeded) suggestion
scsi: qla2xxx: Fix BSG job leak on validate flash image error path
In the Linux kernel, the following vulnerability has been resolved: scsi: qla2xxx: Fix BSG job leak on validate flash image error path qla28xx_validate_flash_image() returns QLA_SUCCESS (0) unconditionally, telling the FC BSG transport (fc_bsg_host_dispatch()) that the driver owns and will complete the request. But bsg_job_done() is guarded by "if (!rval)", so on the error path (rval == -EINVAL) neither the driver nor the transport completes the job. The request dangles until it times out, leaking block layer resources. Commit c2c68225b145 ("scsi: qla2xxx: Fix bsg_done() causing double free") added the "if (!rval)" guard to a batch of BSG handlers. That is correct for handlers that also return the error code (the transport then completes the job once via fail_host_msg), but this function returns QLA_SUCCESS unconditionally, so the guard turned a correct single completion into a leak. Always call bsg_job_done(): bsg_reply->result is DID_OK and the error is reported in vendor_rsp[0], and since the function returns 0 the transport will not complete the job a second time.
References
Affected products
- ==74e7458537cd9349cf019862e51491f670871707
- ==f2bbb4db0e4a4fbd5e649c0b5d8733f61da24720
- ==31f33b856d2324d86bcaef295f4d210477a1c018
- ==871f6236da96c4a9712b8a29d7f555f767a47e95
- <7.0
- <5.16
- =<*
- ==708003e1bc857dd014d4c44278d7d77c26f91b1c
- <6.2
- ==057a5bdc481e58ab853117254867ffb22caf9f6e
- <6.13
- <6.20
- ==27ac9679c43a09e54e2d9aae9980ada045b428e0
- <0fb52cc632464b0cd07f970341330466d772efe1
- <6.7
- =<7.2.*
- ==7.0
- <6.19
- <e25241f9fa01fb0c088381a156d84a725b71c1ef
- <5.11