Activity log
- Created & dismissed (max. allowed matches exceeded) suggestion
iio: adc: spear: Initialize completion before requesting IRQ
In the Linux kernel, the following vulnerability has been resolved: iio: adc: spear: Initialize completion before requesting IRQ In the report from Jaeyoung Chung: "spear_adc_probe() in drivers/iio/adc/spear_adc.c registers its interrupt handler with devm_request_irq() before it initializes st->completion with init_completion(). If an interrupt arrives after devm_request_irq() and before init_completion(), the handler calls complete() on an uninitialized completion, causing a kernel panic. The probe path, in spear_adc_probe(): iodev = devm_iio_device_alloc(&pdev->dev, sizeof(*st)); /* st kzalloc-zeroed */ ... retval = devm_request_irq(&pdev->dev, irq, spear_adc_isr, 0, LPC32XXAD_NAME, st); /* register handler */ ... init_completion(&st->completion); /* initialize completion */ spear_adc_isr() calls complete(): complete(&st->completion); If the device raises an interrupt before init_completion() runs, complete() acquires the uninitialized wait.lock and walks the zeroed task_list in swake_up_locked(). The zeroed task_list makes list_empty() return false, so swake_up_locked() dereferences a NULL list entry, triggering a KASAN wild-memory-access." Fix the chance of a spurious IRQ causing an uninitialized pointer dereference by moving init_completion() above devm_request_irq().
References
Affected products
- =<6.6.*
- =<6.1.*
- =<6.12.*
- =<5.10.*
- =<7.1.*
- <eb5b07c9d0ec1a9d4b6871b14793c19967d79dc4
- <37077d8271b1f24894fbc21bca1c4cd337525d31
- =<*
- <3.16
- ==3.16
- <bbfebae473ac2c8a194523b29ccb9b45f02f134c
- <aea8ae6c4d3ed58d9223360f758df6bd8b90c608
- <a50757398794aaa25f908b96c6733e045466cba4
- =<6.18.*
- <f3f90bc7b38ba3ff14f131cea0f8eb77624787a8
- <3ee2128b6f0eb0be7b6cb8f6e0f1f113a65201a0
- =<5.15.*
- <67a49ab41320b3f721ce4be7447754ff040acbd5