Nixpkgs security tracker

Login with GitHub
⚠️ You are using a production deployment that is still only suitable for demo purposes. Any work done in this might be wiped later without notice.

Suggestion detail

Dismissed
(max. allowed matches exceeded)
created 3 weeks, 3 days ago Activity log
  • Created & dismissed (max. allowed matches exceeded) suggestion
can: bcm: add locking when updating filter and timer values

In the Linux kernel, the following vulnerability has been resolved: can: bcm: add locking when updating filter and timer values KCSAN detected a simultaneous access to timer values that can be overwritten in bcm_rx_setup() when updating timer and filter content while bcm_rx_handler(), bcm_rx_timeout_handler() or bcm_rx_thr_handler() run concurrently on incoming CAN traffic. Protect the timer (ival1/ival2/kt_ival1/kt_ival2/kt_lastmsg) and filter (nframes/flags/frames/last_frames) updates in bcm_rx_setup() with a new per-op bcm_rx_update_lock, taken with the matching scope in the RX handlers. memcpy_from_msg() is staged into a temporary buffer before the lock is taken, since it can sleep and must not run under a spinlock. hrtimer_cancel() is always called without bcm_rx_update_lock held, since bcm_rx_timeout_handler()/bcm_rx_thr_handler() take the same lock and a running callback would otherwise deadlock against the canceller. Also close a related race: bcm_rx_setup() cleared the RTR flag in the stored reply frame's can_id as a separate, unprotected step after the frame content was already installed, so a concurrent bcm_rx_handler() could transmit a stale reply with CAN_RTR_FLAG still set. Fold that normalization into the initial frame preparation instead (on the staged buffer for updates, directly on op->frames pre-registration for new ops), so the installed frame is always atomically self-consistent. bcm_rx_handler()'s RX_RTR_FRAME check now takes a lock-protected snapshot of op->flags before deciding whether to call bcm_can_tx(), but does not hold the lock across that call. Also take a lock-protected snapshot of the currframe in bcm_can_tx() to avoid partly overwrites by content updates in bcm_tx_setup(). Finally check if a TX_RESET_MULTI_IDX/SETTIMER might have reset op->currframe between the two locked sections in bcm_can_tx(). Omit calling hrtimer_forward() with zero interval in bcm_rx_thr_handler(). kt_ival2 may have been concurrently cleared by bcm_rx_setup() before it cancels this timer, so check kt_ival2 inside the bcm_rx_update_lock.

Affected products

Linux
  • =<6.6.*
  • =<*
  • <749179c2e25b95d22499ed29096b3e02d6dfd2b4
  • <6.15
  • <834cbca3b12e46887f7a9b35f1981a888360ea4c
  • =<7.1.*
  • ==7595de7bc56e0e52b74e56c90f7e247bf626d628
  • <6.12.101
  • <6.2
  • =<6.18.*
  • ==2a437b86ac5a9893c902f30ef66815bf13587bf6
  • ==8f1c022541bf5a923c8d6fa483112c15250f30a4
  • ==c4e8a172501e677ebd8ea9d9161d97dc4df56fbd
  • <5.11
  • <fc9f5ee1b073bd233d9c604e338af4ebb42cbc33
  • <6.15
  • =<6.12.*
  • <5.16
  • <a7eb6db1cd3f7b556a301dc1265945ad112089f7
  • ==6.15
  • ==fbd8fdc2b218e979cfe422b139b8f74c12419d1f
  • <6.6.148
  • <5.5
  • <19b1994069dd29478ba767de1f98f14a088198dc